Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tbptt self.log flags and other dead code [5/n] #7644

Merged
merged 2 commits into from
May 22, 2021

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented May 21, 2021

What does this PR do?

Remove support for self.log(tbptt_reduce_fx) and self.log(tbptt_pad_token). The flags have been kept in case somebody is passing default kwargs. GitHub code search or google search did not provide any actual uses of these flags, we also don't have any tests for them or mention in the docs.

Also remove the unused gather and padded_gather functions.

Part of #7183

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added this to the v1.4 milestone May 21, 2021
@carmocca carmocca self-assigned this May 21, 2021
@carmocca carmocca changed the title Remove tbptt self.log flags and other dead code Remove tbptt self.log flags and other dead code May 21, 2021
@codecov
Copy link

codecov bot commented May 21, 2021

Codecov Report

Merging #7644 (ff0e656) into master (e16d4fb) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #7644   +/-   ##
======================================
- Coverage      92%     92%   -0%     
======================================
  Files         198     198           
  Lines       12806   12783   -23     
======================================
- Hits        11835   11789   -46     
- Misses        971     994   +23     

@carmocca carmocca changed the title Remove tbptt self.log flags and other dead code Remove tbptt self.log flags and other dead code [5/n] May 21, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@awaelchli awaelchli enabled auto-merge (squash) May 21, 2021 21:05
@carmocca carmocca added the ready PRs ready to be merged label May 21, 2021
@awaelchli awaelchli merged commit a8d9b5f into master May 22, 2021
@awaelchli awaelchli deleted the refactor/tbptt-dead-code-removal branch May 22, 2021 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants