Refactor result handling in training loop #7506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @awaelchli! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-05-12 22:18:05 UTC |
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #7506 +/- ##
=======================================
- Coverage 92% 88% -4%
=======================================
Files 199 198 -1
Lines 13068 12837 -231
=======================================
- Hits 12026 11269 -757
- Misses 1042 1568 +526 |
…nto refactor/training-loop-result
for more information, see https://pre-commit.ci
awaelchli
requested review from
Borda,
carmocca,
justusschock,
kaushikb11,
SeanNaren,
tchaton and
williamFalcon
as code owners
carmocca
approved these changes
May 12, 2021
ananthsub
reviewed
May 12, 2021
Comment on lines
+198
to
+205
| def log_metrics(self, metrics, grad_norm_dict, step=None): | ||
| """Logs the metric dict passed in. | ||
| If `step` parameter is None and `step` key is presented is metrics, | ||
| uses metrics["step"] as a step | ||
|
|
||
| Args: | ||
| metrics (dict): Metric values | ||
| grad_norm_dic (dict): Gradient norms | ||
| grad_norm_dict (dict): Gradient norms |
There was a problem hiding this comment.
nit: could add typehints to signature to reflect docstring
There was a problem hiding this comment.
yes, logger connector will be refactored
the only reason my PR touches this class is because I auto-renamed the variable everywhere.
Comment on lines
667
to
671
| return AttributeDict( | ||
| signal=0, | ||
| grad_norm_dic=grad_norm_dic, | ||
| grad_norm_dict={}, | ||
| training_step_output_for_epoch_end=batch_outputs, | ||
| ) |
There was a problem hiding this comment.
do we want this more strongly typed as a dataclass instead of AttributeDict?
There was a problem hiding this comment.
yes good idea and attribute dict has to change as part of our refactor efforts anyway
ananthsub
approved these changes
May 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Minor refactor, restores a tiny bit of sanity.
Removes the following state on TrainLoop:
_cur_step_result_cur_grad_norm_dicFixes typo in spelling of
grad_norm_dictBefore submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃