-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1 / 3] improvements to saving and loading callback state #6886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello @awaelchli! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-07-28 21:31:21 UTC |
awaelchli
added
bug
Something isn't working
callback
feature
Is an improvement or enhancement
labels
Apr 8, 2021
Codecov Report
@@ Coverage Diff @@
## master #6886 +/- ##
=======================================
Coverage 92% 93%
=======================================
Files 218 169 -49
Lines 14407 13959 -448
=======================================
- Hits 13305 12917 -388
+ Misses 1102 1042 -60 |
ananthsub
reviewed
Apr 13, 2021
awaelchli
force-pushed
the
bugfix/callback-state
branch
from
April 21, 2021 09:10
5f33eff
to
e1d518b
Compare
awaelchli
commented
Apr 21, 2021
awaelchli
changed the title
improvements to saving and loading callback state
[1 / N] improvements to saving and loading callback state
Apr 21, 2021
awaelchli
requested review from
Borda,
justusschock,
kaushikb11,
SeanNaren,
tchaton and
williamFalcon
as code owners
April 21, 2021 09:45
for more information, see https://pre-commit.ci
ananthsub
reviewed
Jul 28, 2021
Borda
approved these changes
Jul 28, 2021
carmocca
approved these changes
Jul 28, 2021
Co-authored-by: Carlos Mocholí <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>
ananthsub
approved these changes
Jul 28, 2021
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Initial PR for an improved state saving and loading for Callbacks.
This is a bugfix, since pickling with the keys
type(callback)
would pickle the callback class source, and this prevents loading the checkpoint outside of PL (when PL not installed).Feature: With a state identifier, we will be able to produce a (more) unique key for the callbacks. It allows us to save more than one of the same type of callback since we can now disambiguate. This PR does not yet add unique identifiers. This will come in a follow up part.
This change is fully backward compatible (old checkpoints can still be loaded the same way).
Part of #6467
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃