prune deprecated EvalResult

[Borda]

What does this PR do?

another pre-step for #5005

Before submitting

• Was this discussed/approved via a GitHub issue? (not for typos and docs)
• Did you read the contributor guideline, Pull Request section?
• Did you make sure your PR does only one thing, instead of bundling different changes together?
• Did you make sure to update the documentation with your changes? (if necessary)
• Did you write any new necessary tests? (not for typos and docs)
• Did you verify new and existing tests pass locally with your changes?
• Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

• Is this pull request ready for review? (if not, please submit in draft mode)
• Check that all items from Before submitting are resolved
• Make sure the title is self-explanatory and the description concisely explains the PR
• Add labels and milestones (and optionally projects) to the PR so it can be classified
• Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 🙃

[codecov]

Codecov Report

Merging #5633 (0d38c5c) into release/1.2-dev (943166b) will increase coverage by 4%.
The diff coverage is 55%.

@@               Coverage Diff                @@
##           release/1.2-dev   #5633    +/-   ##
================================================
+ Coverage               89%     93%    +4%     
================================================
  Files                  153     153            
  Lines                10816   10743    -73     
================================================
+ Hits                  9616    9941   +325     
+ Misses                1200     802   -398     

[tchaton]

LGTM !

[Borda]

failing flake8 and isort are unrelated to this PR and they are fixed in #5647