Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed configure optimizer from dict without "scheduler" key #1443

Merged
merged 4 commits into from
Apr 10, 2020
Merged

Fixed configure optimizer from dict without "scheduler" key #1443

merged 4 commits into from
Apr 10, 2020

Conversation

alexeykarnachev
Copy link
Contributor

@alexeykarnachev alexeykarnachev commented Apr 10, 2020 •
edited
Loading

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?

Fixes #1442

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@pep8speaks
Copy link

pep8speaks commented Apr 10, 2020 •
edited
Loading

Hello @alexeykarnachev! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-04-10 13:58:35 UTC

@mergify mergify bot requested a review from a team April 10, 2020 13:52
@alexeykarnachev alexeykarnachev changed the title Bug configure optimizer dict Fixed configure optimizer from dict without "scheduler" key Apr 10, 2020
@alexeykarnachev alexeykarnachev changed the title Fixed configure optimizer from dict without "scheduler" key [WIP] Fixed configure optimizer from dict without "scheduler" key Apr 10, 2020
@alexeykarnachev alexeykarnachev changed the title [WIP] Fixed configure optimizer from dict without "scheduler" key Fixed configure optimizer from dict without "scheduler" key Apr 10, 2020
@williamFalcon williamFalcon merged commit 4c34d16 into Lightning-AI:master Apr 10, 2020
@Borda Borda added the bug Something isn't working label Apr 10, 2020
@Borda Borda added this to the 0.7.3 milestone Apr 10, 2020
@alexeykarnachev alexeykarnachev deleted the bug-configure-optimizer-dict branch April 15, 2020 08:54
tullie pushed a commit to tullie/pytorch-lightning that referenced this pull request Jun 7, 2020
@alexeykarnachev @tullie
Fixed configure optimizer from dict without "scheduler" key (Lightnin…
bb68760 
…g-AI#1443)

* `configure_optimizer` from dict with only "optimizer" key. bug fixed

* autopep8

* pep8speaks suggested fixes

* CHANGELOG.md upd
@Borda Borda modified the milestones: 0.7.3, v0.7.x Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
pl:0.7.x
Development

Successfully merging this pull request may close these issues.

Failed to configure_optimizers from dictionary without lr_scheduler field presented
4 participants
@alexeykarnachev @pep8speaks @williamFalcon @Borda