-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add auto_device_count
method to Accelerators
#10222
Conversation
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Copying this because we commented at the same time)
@carmocca Then how could we have it as abstract then?
you could "simulate" it by having it return it Optional[int] = None in "Accelerator" and checking that it's not None when you use the value
No strong feelings though. Up to you
get_devices_when_set_to_auto
method to Accelerators
auto_device_count
method to Accelerators
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
What does this PR do?
Follow up PR will be adding support for
devices="auto"
, where the accelerator will have the info what’s the maximum devices available to train on.Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃