Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto_device_count method to Accelerators #10222

Merged
merged 9 commits into from
Oct 29, 2021
Merged

Conversation

kaushikb11
Copy link
Contributor

What does this PR do?

Follow up PR will be adding support for devices="auto", where the accelerator will have the info what’s the maximum devices available to train on.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@kaushikb11 kaushikb11 added feature Is an improvement or enhancement design Includes a design discussion labels Oct 28, 2021
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@kaushikb11 kaushikb11 added this to the v1.5 milestone Oct 28, 2021
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Copying this because we commented at the same time)

@carmocca Then how could we have it as abstract then?

you could "simulate" it by having it return it Optional[int] = None in "Accelerator" and checking that it's not None when you use the value

No strong feelings though. Up to you

@mergify mergify bot added the ready PRs ready to be merged label Oct 29, 2021
@kaushikb11 kaushikb11 changed the title Add get_devices_when_set_to_auto method to Accelerators Add auto_device_count method to Accelerators Oct 29, 2021
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@kaushikb11 kaushikb11 enabled auto-merge (squash) October 29, 2021 19:13
@kaushikb11 kaushikb11 merged commit cedaebf into master Oct 29, 2021
@kaushikb11 kaushikb11 deleted the support/devices_auto branch October 29, 2021 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Includes a design discussion feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants