Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ClusterEnvironment.creates_processes #10106

Merged
merged 11 commits into from
Oct 25, 2021

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Oct 24, 2021

What does this PR do?

Part of #6303

The name/method creates_children in the cluster environment plugins is supposed to indicate whether the cluster is creating the processes or not. The naming here turned out to be confusing and ambiguous. Here is a proposal to name it more explicitly. Suggestions for alternatives welcome.

@ananthsub

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

Part of #1 (it's a lie, this is just here to avoid noisy GitHub bot)

@awaelchli awaelchli changed the title rename creates_processes to creates_processes_externally rename ClusterEnvironment.creates_processes Oct 24, 2021
@awaelchli awaelchli added design Includes a design discussion deprecation Includes a deprecation refactor labels Oct 24, 2021
@awaelchli awaelchli added this to the v1.5 milestone Oct 24, 2021
@awaelchli awaelchli changed the title rename ClusterEnvironment.creates_processes Rename ClusterEnvironment.creates_processes Oct 24, 2021
@awaelchli awaelchli marked this pull request as ready for review October 24, 2021 21:27
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Oct 25, 2021
@codecov
Copy link

codecov bot commented Oct 25, 2021

Codecov Report

Merging #10106 (1c99b11) into master (9b21ecb) will increase coverage by 4%.
The diff coverage is 100%.

❗ Current head 1c99b11 differs from pull request most recent head a37b71e. Consider uploading reports for the commit a37b71e to get more accurate results

@@           Coverage Diff            @@
##           master   #10106    +/-   ##
========================================
+ Coverage      89%      92%    +4%     
========================================
  Files         182      182            
  Lines       16111    16121    +10     
========================================
+ Hits        14273    14904   +631     
+ Misses       1838     1217   -621     

@tchaton tchaton enabled auto-merge (squash) October 25, 2021 11:26
@mergify mergify bot removed the has conflicts label Oct 25, 2021
@tchaton tchaton merged commit 21a5867 into master Oct 25, 2021
@tchaton tchaton deleted the refactor/rename-creates-children branch October 25, 2021 23:15
ninginthecloud pushed a commit to ninginthecloud/pytorch-lightning that referenced this pull request Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation Includes a deprecation design Includes a design discussion ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants