-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename master_params
to main_params
#10105
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
changed the title
Rename
Rename Oct 24, 2021
PrecisionPlugin.master_params
to PrecisionPlugin.main_params
master_params
to main_params
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
@awaelchli Still Draft? |
awaelchli
requested review from
Borda,
carmocca,
justusschock,
kaushikb11,
rohitgr7,
SeanNaren,
tchaton and
williamFalcon
as code owners
October 25, 2021 07:43
nope! |
tchaton
approved these changes
Oct 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
rohitgr7
approved these changes
Oct 25, 2021
Codecov Report
@@ Coverage Diff @@
## master #10105 +/- ##
========================================
+ Coverage 89% 93% +4%
========================================
Files 182 182
Lines 16159 16162 +3
========================================
+ Hits 14333 14952 +619
+ Misses 1826 1210 -616 |
carmocca
approved these changes
Oct 25, 2021
Co-authored-by: Rohit Gupta <[email protected]>
for more information, see https://pre-commit.ci
justusschock
approved these changes
Oct 25, 2021
for more information, see https://pre-commit.ci
Borda
approved these changes
Oct 25, 2021
for more information, see https://pre-commit.ci
ninginthecloud
pushed a commit
to ninginthecloud/pytorch-lightning
that referenced
this pull request
Oct 27, 2021
Co-authored-by: tchaton <[email protected]> Co-authored-by: Rohit Gupta <[email protected]>
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
deprecation
Includes a deprecation
design
Includes a design discussion
priority: 1
Medium priority task
ready
PRs ready to be merged
refactor
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Tangential to #8774
We want to clean up our code of words and expressions that could have negative connotations.
Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃
Part of #1 (it's a lie, this is just here to avoid noisy GitHub bot)