Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename master_params to main_params #10105

Merged
merged 15 commits into from
Oct 26, 2021
Merged

Conversation

awaelchli
Copy link
Contributor

What does this PR do?

Tangential to #8774

We want to clean up our code of words and expressions that could have negative connotations.

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

Part of #1 (it's a lie, this is just here to avoid noisy GitHub bot)

@awaelchli awaelchli changed the title Rename PrecisionPlugin.master_params to PrecisionPlugin.main_params Rename master_params to main_params Oct 24, 2021
@awaelchli awaelchli added deprecation Includes a deprecation refactor labels Oct 24, 2021
@awaelchli awaelchli added this to the v1.5 milestone Oct 24, 2021
@awaelchli awaelchli added the priority: 1 Medium priority task label Oct 24, 2021
@kaushikb11
Copy link
Contributor

@awaelchli Still Draft?

@awaelchli
Copy link
Contributor Author

nope!

@awaelchli awaelchli added the design Includes a design discussion label Oct 25, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Oct 25, 2021
@codecov
Copy link

codecov bot commented Oct 25, 2021

Codecov Report

Merging #10105 (d52ceb1) into master (21a5867) will increase coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           master   #10105    +/-   ##
========================================
+ Coverage      89%      93%    +4%     
========================================
  Files         182      182            
  Lines       16159    16162     +3     
========================================
+ Hits        14333    14952   +619     
+ Misses       1826     1210   -616     

@awaelchli awaelchli enabled auto-merge (squash) October 25, 2021 11:49
@mergify mergify bot removed the has conflicts label Oct 25, 2021
@mergify mergify bot removed the has conflicts label Oct 25, 2021
@awaelchli awaelchli merged commit 871a967 into master Oct 26, 2021
@awaelchli awaelchli deleted the refactor/rename-master-params branch October 26, 2021 09:17
ninginthecloud pushed a commit to ninginthecloud/pytorch-lightning that referenced this pull request Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation Includes a deprecation design Includes a design discussion priority: 1 Medium priority task ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants