-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate lr_sch_names
from LearningRateMonitor
#10066
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohitgr7
requested review from
awaelchli,
Borda,
carmocca,
justusschock,
kaushikb11,
SeanNaren,
tchaton and
williamFalcon
as code owners
October 21, 2021 10:32
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
carmocca
reviewed
Oct 21, 2021
rohitgr7
commented
Oct 21, 2021
awaelchli
approved these changes
Oct 21, 2021
carmocca
approved these changes
Oct 21, 2021
tchaton
approved these changes
Oct 21, 2021
rohitgr7
force-pushed
the
dep/lr_sch_names
branch
from
October 21, 2021 21:13
e0528d3
to
62303bb
Compare
Codecov Report
@@ Coverage Diff @@
## master #10066 +/- ##
=========================================
+ Coverage 89% 93% +4%
=========================================
Files 180 182 +2
Lines 16146 16944 +798
=========================================
+ Hits 14317 15745 +1428
+ Misses 1829 1199 -630 |
Borda
reviewed
Oct 25, 2021
rohitgr7
force-pushed
the
dep/lr_sch_names
branch
from
October 26, 2021 21:46
c302980
to
2760cf0
Compare
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
See title
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃