-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename TPUHalfPrecisionPlugin
to TPUBf16PrecisionPlugin
#10026
Conversation
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Codecov Report
@@ Coverage Diff @@
## master #10026 +/- ##
========================================
- Coverage 93% 89% -4%
========================================
Files 180 180
Lines 15854 15870 +16
========================================
- Hits 14678 14075 -603
- Misses 1176 1795 +619 |
Are we worried about backwards compatibility here, or is that primarily around API changes? |
We would if the API was stable. In the past, we've still added deprecation paths for very popular plugins or hooks. I don't think that's the case with the |
Co-authored-by: Adrian Wälchli <[email protected]>
What does this PR do?
Fixes #10020 (comment)
Rename
TPUHalfPrecisionPlugin
toTPUBf16PrecisionPlugin
And prints a warning when the user sets
precision=16
for TPUs as they only really support "bf16".Does your PR introduce any breaking changes? If yes, please list them.
The class name has changed
Before submitting
PR review