Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename TPUHalfPrecisionPlugin to TPUBf16PrecisionPlugin #10026

Merged
merged 8 commits into from
Oct 19, 2021

Conversation

carmocca
Copy link
Contributor

What does this PR do?

Fixes #10020 (comment)

Rename TPUHalfPrecisionPlugin to TPUBf16PrecisionPlugin
And prints a warning when the user sets precision=16 for TPUs as they only really support "bf16".

Does your PR introduce any breaking changes? If yes, please list them.

The class name has changed

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Oct 19, 2021
@codecov
Copy link

codecov bot commented Oct 19, 2021

Codecov Report

Merging #10026 (e75171c) into master (e8beceb) will decrease coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           master   #10026    +/-   ##
========================================
- Coverage      93%      89%    -4%     
========================================
  Files         180      180            
  Lines       15854    15870    +16     
========================================
- Hits        14678    14075   -603     
- Misses       1176     1795   +619     

@edward-io
Copy link
Contributor

Are we worried about backwards compatibility here, or is that primarily around API changes?

@carmocca
Copy link
Contributor Author

carmocca commented Oct 19, 2021

Are we worried about backwards compatibility here, or is that primarily around API changes?

We would if the API was stable.

In the past, we've still added deprecation paths for very popular plugins or hooks. I don't think that's the case with the TPUHalfPrecisionPlugin

CHANGELOG.md Outdated Show resolved Hide resolved
@carmocca carmocca enabled auto-merge (squash) October 19, 2021 20:41
@carmocca carmocca merged commit d45897d into master Oct 19, 2021
@carmocca carmocca deleted the refactor/rename-tpu-half-plugin branch October 19, 2021 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants