Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DDPSpawnPlugin.spawn() #10018

Merged
merged 6 commits into from
Oct 19, 2021
Merged

Add DDPSpawnPlugin.spawn() #10018

merged 6 commits into from
Oct 19, 2021

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Oct 19, 2021

What does this PR do?

Part of #9987

Adds a spawn() method for creating new processes. This new API can be independently called (from outside the trainer) and is specific to the Spawn family of plugins (TPUSpawn, ShardedSpawn, etc.). This PR adds the base method and replaces calls to mp.spawn elsewhere with this new method.

Does your PR introduce any breaking changes? If yes, please list them.

Yes, process idx was removed from the method DDPSpawnPlugin.new_process. The TPUSpawnPlugin will be updated separately in a new PR.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

@awaelchli awaelchli added design Includes a design discussion refactor labels Oct 19, 2021
@awaelchli awaelchli added this to the v1.5 milestone Oct 19, 2021
Copy link
Contributor

@kaushikb11 kaushikb11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mergify mergify bot added the ready PRs ready to be merged label Oct 19, 2021
@kaushikb11
Copy link
Contributor

@awaelchli There are some failing tests, regarding passing parameters to the new_process method

@awaelchli awaelchli enabled auto-merge (squash) October 19, 2021 13:42
@awaelchli awaelchli merged commit bcb94de into master Oct 19, 2021
@awaelchli awaelchli deleted the lightning-lite/refactors/spawn branch October 19, 2021 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Includes a design discussion ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants