-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise MisconfigurationException
if trainer.eval
is missing required methods
#10016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohitgr7
commented
Oct 19, 2021
rohitgr7
commented
Oct 19, 2021
rohitgr7
commented
Oct 19, 2021
rohitgr7
requested review from
awaelchli,
Borda,
carmocca,
justusschock,
kaushikb11,
SeanNaren,
tchaton and
williamFalcon
as code owners
October 19, 2021 15:16
Codecov Report
@@ Coverage Diff @@
## master #10016 +/- ##
=======================================
- Coverage 93% 93% -0%
=======================================
Files 182 182
Lines 16147 16149 +2
=======================================
+ Hits 14937 14938 +1
- Misses 1210 1211 +1 |
carmocca
reviewed
Oct 19, 2021
awaelchli
approved these changes
Oct 19, 2021
11 tasks
rohitgr7
commented
Oct 20, 2021
kaushikb11
approved these changes
Oct 25, 2021
Borda
approved these changes
Oct 25, 2021
ninginthecloud
pushed a commit
to ninginthecloud/pytorch-lightning
that referenced
this pull request
Oct 27, 2021
27 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Follow up: #9976
More info: #9976 (comment)
In short
trainer.predict
raises an exception buttrainer.validate/test
doesn't in case eval_step/eval_dataloader is missing.Also did a little cleanup and a small bugfix which came up after the changes.
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃