-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update metrics to use Enum #5657
Comments
I could give it a shot. something like this |
The |
fine with
? Otherwise |
- change data type string to DataType enum - add enum equality test - update test_inputs.py to use the defined enum type
- change data type string to DataType enum - add enum equality test - update test_inputs.py to use the defined enum type update doc
- change data type string to DataType enum - add enum equality test - update test_inputs.py to use the defined enum type update doc
* remove AverageMethods enum from functional/auroc.py
* remove AverageMethods enum from functional/auroc.py
* remove AverageMethods enum from functional/auroc.py
* remove AverageMethods enum from functional/auroc.py
- Add DataType, AverageMethod and MDMCAverageMethod
- Add DataType, AverageMethod and MDMCAverageMethod
- Add DataType, AverageMethod and MDMCAverageMethod
- Add DataType, AverageMethod and MDMCAverageMethod
Closed by PR #5689 |
🚀 Feature
Motivation
Update metrics package to use
Enum
where it makes sense. For example:https://github.com/PyTorchLightning/pytorch-lightning/blob/f78223041283450c98fb34bb23bea6706247d937/pytorch_lightning/metrics/classification/helpers.py#L79-L87
the
case
(data type) could be made an enum typePitch
Alternatives
Additional context
@Borda
The text was updated successfully, but these errors were encountered: