Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Support NP_EXTENSIONS for SemanticSegmentationFilesInput #1369

Merged
merged 6 commits into from
Jul 14, 2022

Conversation

krshrimali
Copy link
Contributor

@krshrimali krshrimali commented Jun 30, 2022

What does this PR do?

As per the title. Fixes #1308.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jun 30, 2022

Codecov Report

Merging #1369 (496de60) into master (fd8cc7f) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1369   +/-   ##
=======================================
  Coverage   92.93%   92.93%           
=======================================
  Files         285      285           
  Lines       12778    12778           
=======================================
  Hits        11875    11875           
  Misses        903      903           
Flag Coverage Δ
unittests 92.93% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/image/segmentation/data.py 100.00% <ø> (ø)
flash/core/data/utilities/loading.py 97.10% <100.00%> (ø)
flash/image/segmentation/input.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd8cc7f...496de60. Read the comment docs.

@ethanwharris ethanwharris added this to the 0.8.0 milestone Jul 11, 2022
@mergify mergify bot removed the has conflicts label Jul 14, 2022
@ethanwharris ethanwharris added the bug / fix Something isn't working label Jul 14, 2022
@ethanwharris ethanwharris merged commit 95e19d3 into master Jul 14, 2022
@ethanwharris ethanwharris deleted the fix/semantic_segmentation_np_extensions branch July 14, 2022 20:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug / fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SemanticSegmentationFilesInput does not accept .npy files
2 participants