-
Notifications
You must be signed in to change notification settings - Fork 212
fix SpeechRecognitionOutputTransform if local #1362
Conversation
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #1362 +/- ##
==========================================
- Coverage 92.71% 92.69% -0.02%
==========================================
Files 286 286
Lines 12814 12814
==========================================
- Hits 11880 11878 -2
- Misses 934 936 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, LGTM 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @flozi00 for the PR. LGTM, would you also like adding a brief description of this arg processor_backbone
to the docstring of SpeechRecognition
class? Here: https://github.com/Lightning-AI/lightning-flash/blob/ba7cb1c3bb7c52197f2cb3aedc36981d00df9e4e/flash/audio/speech_recognition/model.py#L42
If you decide to make another PR for that, that also works. But let's not block this PR for the change, I'll merge this now. 🎉 Thank you for your contribution.
What does this PR do?
Fixes # (issue)
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃