Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Update formatting targets guide #1165

Merged
merged 7 commits into from
Feb 14, 2022
Merged

Conversation

ethanwharris
Copy link
Collaborator

@ethanwharris ethanwharris commented Feb 11, 2022

What does this PR do?

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Feb 11, 2022

Codecov Report

Merging #1165 (b79863a) into master (3ec0405) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1165      +/-   ##
==========================================
- Coverage   89.26%   89.26%   -0.01%     
==========================================
  Files         286      286              
  Lines       13048    13045       -3     
==========================================
- Hits        11647    11644       -3     
  Misses       1401     1401              
Flag Coverage Δ
unittests 89.26% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/core/data/utilities/classification.py 98.22% <ø> (ø)
flash/core/data/data_module.py 95.23% <100.00%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ec0405...b79863a. Read the comment docs.

@ethanwharris ethanwharris added the documentation Improvements or additions to documentation label Feb 11, 2022
@ethanwharris ethanwharris added this to the v0.7 milestone Feb 11, 2022
@ethanwharris ethanwharris marked this pull request as ready for review February 11, 2022 17:19
docs/source/general/classification_targets.rst Outdated Show resolved Hide resolved
docs/source/general/classification_targets.rst Outdated Show resolved Hide resolved
docs/source/general/classification_targets.rst Outdated Show resolved Hide resolved
docs/source/general/classification_targets.rst Outdated Show resolved Hide resolved
docs/source/general/classification_targets.rst Outdated Show resolved Hide resolved
@ethanwharris ethanwharris merged commit defbace into master Feb 14, 2022
@ethanwharris ethanwharris deleted the docs/classification_targets branch February 14, 2022 12:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants