-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove numpy pin #332
base: master
Are you sure you want to change the base?
Remove numpy pin #332
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #332 +/- ##
==========================================
- Coverage 86.00% 84.98% -1.03%
==========================================
Files 17 17
Lines 4209 4209
Branches 989 989
==========================================
- Hits 3620 3577 -43
- Misses 430 473 +43
Partials 159 159 ☔ View full report in Codecov by Sentry. |
Some tests on Windows also fail. This is not urgent, but feel free to dig in. |
Not what I expected, and I'm not using Windows. Comparing the My guess is that there's some kind of incompatibility with numpy still, but I'm struggling to troubleshoot this since Happy to help further, but I'm slowly running out of ideas. Maybe it's still best to hold off on removing the numpy pin for now and hope the responsible party releases a fix soon. |
To prevent windows from blocking this change, platform specifier could be used for numpy?
|
pyproject.toml
Outdated
"numpy"; sys_platform != 'win32' | ||
"numpy"<2; sys_platform == 'win32' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"numpy"; sys_platform != 'win32' | |
"numpy"<2; sys_platform == 'win32' | |
"numpy"; sys_platform != 'win32', | |
"numpy"<2; sys_platform == 'win32', |
@ollie-bell I think that is a good idea. applied it. @glatterf42 sorry for the mess, was trying to do it on GH with suggestions first... |
Gurobipy v11.0.3 was released on July 16 and seems to be compatible with numpy >= 2.0.0. At least locally, running the tests via
pytest .
and an editable install from this branch with numpy 2.0.1 and gurobipy 11.0.3, all tests are passing :)The only thing I can't quite make sense of is this warning: