Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script=True only support Snake Case script #191

Closed
williamstar opened this issue Nov 29, 2021 · 4 comments · Fixed by #205
Closed

Script=True only support Snake Case script #191

williamstar opened this issue Nov 29, 2021 · 4 comments · Fixed by #205

Comments

@williamstar
Copy link

williamstar commented Nov 29, 2021

Most of binary executable filename is Kebab Case, but currently is not support in setuptools-rust.

It seems that script name is shared with python module name from the codebase and python module name is not support Kebab Case.

For example, the origin rust_extension is persia-embedding-parameter-server will rename to persia_embedding_parameter_server.And we want to keep the original binary name but failed.

Is there any solution to fix this problem or can i propose a PR try to support Kebab Case?

@davidhewitt
Copy link
Member

A PR to support kebab-case is very welcome 👍

@williamstar
Copy link
Author

Ok, I will have a try. 😃

@davidhewitt
Copy link
Member

Great! Please do ask if you have any questions about possible implementation or design.

@williamstar
Copy link
Author

Accept a dict to get the script name from the target.values . I'm not sure if the design is good.

#199

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants