Maturin sdists fails on Windows when using local dependencies

[andfoy]

Please provide the following information:

• Your python version (python -V): 3.x
• Your pip version (pip -V):
  • If this isn't the latest pip version, have you checked using the latest pip version?
• The version of the bindings you're using, if any (e.g. pyo3, rust-cpython or cffi): 0.13.2
• Does cargo build work? Yes
• If on windows, have you checked that you aren't accidentally using unix path (those with the forward slash /)? Yes

Hi,

I've been trying to provide a source distribution for pywinpty (https://github.com/spyder-ide/pywinpty), which only works for Windows. This package depends on pywinpty_findlib, which is a local dependency that is specified in the Cargo.toml as follows:

[build-dependencies]
cxx-build = {version = "1.0.45", features = ["parallel"]}
pywinpty_findlib = { version = "=0.3.0", path = "findlib" }
which = "4.1.0"

When I try to invoke maturin sdist, it fails with the following message:

💥 maturin failed
  Caused by: Failed to build source distribution
  Caused by: Failed to add local dependency pywinpty_findlib at /C:/Users/quansight/pywinpty/findlib to the source distribution
  Caused by: Failed to query file list from cargo: exit code: 101
--- Stdout:

--- Stderr:
error: manifest path `/C:/Users/quansight/pywinpty/findlib\Cargo.toml` does not exist

My guess is that for some reason, forward and backward slashes are getting mixed up, which is preventing the correct localization of the local dependency Cargo.toml. This also occurs when calling maturin build, but not when calling maturin develop

[messense]

It seems that on Windows cargo prints "pywinpty_findlib 0.3.0 (path+file:///Y:/Downloads/pywinpty/findlib)", so the regex here

maturin/src/source_distribution.rs

Line 175 in 3e2b8b0

let matcher = Regex::new(r"^(.*) .* \(path\+file://(.*)\)$").unwrap();

extracts /Y:/Downloads/pywinpty/findlib with a leading slash which caused the error.

Change the offending line to let matcher = Regex::new(r"^(.*) .* \(path\+file:///?(.*)\)$").unwrap(); could fix this on Windows but breaks Unix, then I hit alexcrichton/tar-rs#251 in maturin debug build (works fine in release build).

[messense]

BTW, your pyproject.toml is missing the project.name field which is required by PEP 621.

[andfoy]

Hi @messense, thanks for the heads up! I've just updated pywinpty accordingly

[messense]

@andfoy Please try v0.11.0-beta.5: pip install --pre -U maturin