Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated CI produces mis-aligned YAML #2339

Closed
2 tasks
jsstevenson opened this issue Nov 29, 2024 · 0 comments · Fixed by #2340
Closed
2 tasks

Generated CI produces mis-aligned YAML #2339

jsstevenson opened this issue Nov 29, 2024 · 0 comments · Fixed by #2340
Labels
bug Something isn't working

Comments

@jsstevenson
Copy link
Contributor

Bug Description

The generated GitHub Actions yaml which uses the relatively new Python 3.13t logic includes a little extra indentation, making it invalid. See for example lines 51-57 in this gist:

https://gist.github.com/jsstevenson/71c529f2227b4484cf1e1c19f92b43c9#file-maturin_generated_ci-yaml-L51-L57

(it's also misaligned in the other places where this code is reused)

Your maturin version (maturin --version)

1.7.6

Your Python version (python -V)

3.12.2

Your pip version (pip -V)

24.3.1

What bindings you're using

pyo3

Does cargo build work?

  • Yes, it works

If on windows, have you checked that you aren't accidentally using unix path (those with the forward slash /)?

  • Yes

Steps to Reproduce

maturin generate-ci github -o release.yaml to generate the gist linked above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant