Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uniffi-bindgen required to be installed for maturin to work #1658

Closed
heinrich5991 opened this issue Jun 9, 2023 · 6 comments · Fixed by #1762
Closed

uniffi-bindgen required to be installed for maturin to work #1658

heinrich5991 opened this issue Jun 9, 2023 · 6 comments · Fixed by #1762
Labels
bindings/uniffi uniffi bindings enhancement New feature or request

Comments

@heinrich5991
Copy link

uniffi-bindgen needs to be installed in some way in order for maturin to work with uniffi bindings.

It'd be nice if the correct version of uniffi-bindgen could be used automatically, e.g. by adding a workspace crate like described in https://github.com/mozilla/uniffi-rs/blob/62979fa0899b74f29db48d715da20ea514e400fe/docs/manual/src/tutorial/foreign_language_bindings.md#multi-crate-workspaces.

Would something like this be interesting for this project?

@heinrich5991 heinrich5991 added the enhancement New feature or request label Jun 9, 2023
@messense
Copy link
Member

messense commented Jun 10, 2023

At the moment I've published pre-built uniffi-bindgen to pypi to improve build speed: https://github.com/messense/crate-wheels/blob/main/.github/workflows/uniffi-bindgen.yml, we can certainly also support the official documented method.

@messense messense added the bindings/uniffi uniffi bindings label Jun 10, 2023
@heinrich5991
Copy link
Author

That makes sense. I'm facing the problem that I can't use this, as my project needs the current uniffi-bindgen master.

@messense
Copy link
Member

Now that uniffi released 0.24, I think you can use it?

@heinrich5991
Copy link
Author

Yes. This problem no longer affects me as much.

@messense
Copy link
Member

Will be fixed in #1729.

@heinrich5991
Copy link
Author

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bindings/uniffi uniffi bindings enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants