Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate macOS platform tag based on the dylib build version #1252

Closed
messense opened this issue Nov 7, 2022 · 1 comment · Fixed by #1536
Closed

Generate macOS platform tag based on the dylib build version #1252

messense opened this issue Nov 7, 2022 · 1 comment · Fixed by #1536
Labels
enhancement New feature or request wheel Wheel
Milestone

Comments

@messense
Copy link
Member

messense commented Nov 7, 2022

Currently it's hard coded if MACOSX_DEPLOYMENT_TARGET env var isn't set

maturin/src/target.rs

Lines 685 to 686 in cb0b6c6

let x86_64_default = if universal2 { (10, 9) } else { (10, 7) };
let arm64_default = (11, 0);

@messense
Copy link
Member Author

I think in reality it's not a good idea to do this because it will end up generating wheels that can only be installed on newer versions of macOS.

Always setting MACOSX_DEPLOYMENT_TARGET is still a good idea, but I think we should add a option in [tool.maturin] like macos-deployment-target to allow projects to declare a default target version, instead of relying on querying the one that rustc support because there might be some C/C++ dependencies that requires higher macOS SDK versions than rustc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wheel Wheel
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant