From c470feea49a3c801f8a20c0d4ce53bb5793375b0 Mon Sep 17 00:00:00 2001 From: messense Date: Wed, 29 Dec 2021 14:16:46 +0800 Subject: [PATCH] Fix compiling on Windows Disable Windows zig test for now --- .github/workflows/test.yml | 1 + src/compile.rs | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 780e125c2..54e3086bc 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -110,6 +110,7 @@ jobs: with: python-version: "3.10.0" - name: test cross compiling with zig + if: matrix.os != 'windows-latest' run: | rustup target add aarch64-unknown-linux-gnu cargo run -- build --no-sdist -i python -m test-crates/pyo3-pure/Cargo.toml --target aarch64-unknown-linux-gnu --zig diff --git a/src/compile.rs b/src/compile.rs index bbf72cc0e..48d509d3b 100644 --- a/src/compile.rs +++ b/src/compile.rs @@ -183,7 +183,7 @@ fn create_linker_script(path: &Path) -> Result { #[cfg(not(target_family = "unix"))] fn create_linker_script(path: &Path) -> Result { - File::create(path) + Ok(File::create(path)?) } fn compile_target(