Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the rest of linting rules #68

Open
ddundo opened this issue Feb 16, 2025 · 0 comments
Open

Fix the rest of linting rules #68

ddundo opened this issue Feb 16, 2025 · 0 comments
Labels

Comments

@ddundo
Copy link
Member

ddundo commented Feb 16, 2025

In #62 I added a Ruff linter, but I ignored errors that couldn't be fixed automatically - see below. We should manually fix them.

ignore = [
    "B006",  # Mutable data structures in argument defaults
    "B007",  # Loop control variable not used within loop body
    "B008",  # Function call `range` in argument defaults
    "B023",  # Function definition does not bind loop variable
    "C405",  # Unnecessary list literal
    "C408",  # Unnecessary `dict()` call
    "C414",  # Unnecessary `list()` call
    "C416",  # Unnecessary list comprehension
    "C901",  # Function too complex
    "E402",  # Module level import not at top of file
    "E501",  # Line too long
    "E712",  # Avoid equality comparisons to `False`
    "E721",  # Use `is` and `is not` for type comparisons, or `isinstance()`
    "E722",  # Using bare `except`
    "F841",  # Local variable assigned to but never used
]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant