Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #167: Check if stdin is a terminal before calling termios on it #198

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

josh-marshall-amp
Copy link
Contributor

On *nix, check if stdin is a terminal before calling termios on it as those operations fail on a pipe, ie when running pytest.

…ose operations fail on a pipe, ie when running pytest. Fix for #167, tests fail on macOS.
@josh-marshall-amp josh-marshall-amp linked an issue Jul 22, 2024 that may be closed by this pull request
@josh-marshall-amp josh-marshall-amp self-assigned this Jul 22, 2024
Copy link
Collaborator

@clint-lawrence clint-lawrence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Ages ago, I had tried to keep this running on MacOS and Linux, so more than happy for small fixes to get that back.

@josh-marshall-amp josh-marshall-amp merged commit dd5ea1f into master Jul 22, 2024
9 checks passed
@clint-lawrence clint-lawrence deleted the 167-tests-fail-on-macos branch August 6, 2024 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests fail on MacOS
2 participants