You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Our build server pulled in the latest this morning, and we saw failures on files which should be valid because of this.
pycodestyle 2.1.0 seems to be matching for E305 on lines with def or class as a prefix, when it should be looking for def and class .
Simple example:
classic_value=0default_foo=1default_bar=2
Those second two lines will be flagged for E305 because there isn't enough whitepace after classic_value or default_foo.
Fix should be simple -- make sure that match requires whitespace -- and this needs a testcase too. I'll be fixing my own code to get past the slightly broken validation, then look into submitting a PR if I can figure out this codebase (never made a contribution before).
As always, thanks for great tools!
EDIT: This can be considered a duplicate of #593 . Sorry for not finding that before submitting.
The text was updated successfully, but these errors were encountered:
Let's go ahead and close this since it's fixed. Based some some comments, I think 2.2.0 is going to end up getting released shortly, which will address this. Thanks for catching this @sirosen !
Our build server pulled in the latest this morning, and we saw failures on files which should be valid because of this.
pycodestyle 2.1.0 seems to be matching for E305 on lines with
def
orclass
as a prefix, when it should be looking fordef
andclass
.Simple example:
Those second two lines will be flagged for E305 because there isn't enough whitepace after
classic_value
ordefault_foo
.Fix should be simple -- make sure that match requires whitespace -- and this needs a testcase too. I'll be fixing my own code to get past the slightly broken validation, then look into submitting a PR if I can figure out this codebase (never made a contribution before).
As always, thanks for great tools!
EDIT: This can be considered a duplicate of #593 . Sorry for not finding that before submitting.
The text was updated successfully, but these errors were encountered: