Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-commit hook/sort logic differences between 4.3.4 and 4.3.21/latest version #1167

Closed
darrenaalfonso opened this issue Mar 18, 2020 · 1 comment

Comments

@darrenaalfonso
Copy link

I want to use the isort pre-commit hook for a project I'm working on/just joined. The problem is, that the current version is 4.3.21 while the rest of the devs are on 4.3.4. With the same settings, the output of 4.3.4 is much different than 4.3.21. My initial solution was to use the 4.3.4 commit hook, but it seems like pre-commit hooks weren't supported for that version. Any advice? Is there a way to get 4.3.21 to sort imports in the same order as 4.3.4?

@darrenaalfonso
Copy link
Author

Figured it out, was a combination of different isort.cfg and also related to environments #1147

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant