Speed and error handling imrovements for project timeline webpart #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to fix issue if a project's site has been changed
This is to fix issue if a project's site has been changed
Remi749
added
bug
Remi749
added a commit
that referenced
this pull request
Sep 14, 2022
* Risk matrix can now be customized * If custom cells is found, these will be used over standard cells. * Update after test * Linting * Removed some styling * "Stop function" when someone tries to add site template "Prosjektområde" at portfolio level (#748) * Update changelog + fix grammar * fix for #648 using /_api/siteiconmanager/getsitelogo instead of base64 from graph (#751) * using /_api/siteiconmanager/getsitelogo instead of base64 representation of logo loaded from the graph. removing functionality for getting logos from graph * updating changelog * removing unused imports * adding flag to UpgradeAllSitesToLatest and capability for adding plans to project sites missing a planner plan (#753) Looks great, thanks @okms * minor: changing to -UseWebLogin in order to target legacy PnP powershell module * Add PERMISSIONS markdown file + Readme for sitescripts * Update PERMISSIONS.md * Fix for bug where default column values were wiped when importing documents through TemplateSelector dialog (#769) * Replace addChunked with addUsingPath to persist location default values * Update to changelog * Update ReactMarkdown to latest throughout solution (#770) * Update ReactMarkdown to latest throughout solution * Remove children prop from ReactMarkdown * Speed and error handling imrovements for project timeline webpart (#771) * Use siteId when grouping timeline elements This is to fix issue if a project's site has been changed * Use siteId when grouping timeline elements This is to fix issue if a project's site has been changed * Add UserMessage as a shared component * Move FilterPanel and UserMessage to @shared * Revert FilterPanel back to portfoliowebparts and minor fixes * Fix problem with dataSource for BenefitsOverview on Projectlevel * Minor cleanup * Improve error handling of projecttimeline on portfoliolevel * Removed unnecessary calls to timelineconfig list * Fix amount of calls for config and status report data * Add more error handling to Projectlevel timeline * Adjustments to height for timeline on portfoliolevel * Hide error messages in StatusReport regarding Projectproperties * Linting + changelog * Risk matrix can now be customized * If custom cells is found, these will be used over standard cells. * Update after test * Linting * Removed some styling * Update changelog Co-authored-by: Martin Ruud <[email protected]> Co-authored-by: Ole Kristian Mørch-Storstein <[email protected]> Co-authored-by: TinHoangVu <[email protected]> Co-authored-by: Remi Blom-Ohlsen <[email protected]> Co-authored-by: Ole Kristian Mørch-Storstein <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Description
This Pull request improves the load speed for project timeline webpart drastically. For a portfolio of 40 projects this is a before/after of how many calls are now made when loading the timeline webpart (see images)
As well as improving the load speed by reducing the amount of calls needed to fetch data, better error handling has been implemented for the timelines.
Example:
This will give the user exact information as to what has gone wrong. This will fix issue: #755
Additions beyond the relevant issues:
How to test
Relevant issues (if applicable)
#743 , #755