Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for visible check in project information web part #385

Merged
merged 2 commits into from
Feb 11, 2021

Conversation

olemp
Copy link
Collaborator

@olemp olemp commented Feb 11, 2021

Your checklist for this pull request

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your main!
  • Make sure you are making a pull request against the dev branch (left side). Also you should start your branch off dev.
  • Check the commit's or even all commits' message
  • Check your code additions will fail linting checks
  • Remember: Add PR description to Changelog with the ID that matches this PR

Description

Fix for visible check in Project Information web part.

We don't need to check ShowInDisplayForm property.

How to test

See #384

  • [ ]

Relevant issues (if applicable)

Closes #384

@olemp olemp marked this pull request as ready for review February 11, 2021 09:58
@olemp olemp merged commit 462fee6 into dev Feb 11, 2021
@olemp olemp deleted the feature/project-information-webpart-384 branch February 11, 2021 09:58
@pzljanb pzljanb mentioned this pull request Feb 12, 2021
25 tasks
@pzljanb
Copy link
Contributor

pzljanb commented Feb 25, 2021

What would be the correct approach to test this implementation @olemp ?

@pzljanb
Copy link
Contributor

pzljanb commented Feb 27, 2021

Have not been able not describe a good testcase for this PR.
But when adding to project properties everything seems to be visible as intended.
With that in mind I assume this is solved.....

@olemp
Copy link
Collaborator Author

olemp commented Feb 27, 2021

Have not been able not describe a good testcase for this PR.
But when adding to project properties everything seems to be visible as intended.
With that in mind I assume this is solved.....

Was hard to make a test case here, very technical. Previously we filtered properties to show in the web part by ShowInDisplayForm property on the related field, and that was no probably. Suddenly it seems all fields have this property set to FALSE by default, so it caused issues to use this property for filtering. We’ll stick to use the field configuration list on portfolio level to choose what fields to show.

@pzljanb pzljanb added this to the 1.2.6 milestone Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ShowInDisplayForm property is added to fields when synchronizing fields from portal site
2 participants