From d2da4f11890ca618d1a854c100068a2a7a4595da Mon Sep 17 00:00:00 2001 From: Ole Martin Pettersen Date: Thu, 30 Mar 2023 13:57:37 +0200 Subject: [PATCH] Minor adjustments to component --- .../LatestGitHubRelease/index.tsx | 4 ++-- .../LatestGitHubRelease/useLatestGitHubRelease.ts | 5 +++++ .../components/Footer/InstallVersionTooltipContent/index.tsx | 4 ++++ .../PortfolioExtensions/src/components/Footer/useFooter.ts | 3 ++- .../PortfolioExtensions/src/loc/myStrings.d.ts | 1 + SharePointFramework/PortfolioExtensions/src/loc/nb-no.js | 3 ++- 6 files changed, 16 insertions(+), 4 deletions(-) diff --git a/SharePointFramework/PortfolioExtensions/src/components/Footer/InstallVersionTooltipContent/LatestGitHubRelease/index.tsx b/SharePointFramework/PortfolioExtensions/src/components/Footer/InstallVersionTooltipContent/LatestGitHubRelease/index.tsx index 33a4e4ea16..41066067e9 100644 --- a/SharePointFramework/PortfolioExtensions/src/components/Footer/InstallVersionTooltipContent/LatestGitHubRelease/index.tsx +++ b/SharePointFramework/PortfolioExtensions/src/components/Footer/InstallVersionTooltipContent/LatestGitHubRelease/index.tsx @@ -16,7 +16,7 @@ export const LatestGitHubRelease: FC = () => {
{strings.LatestGitHubReleaseLabel} - + {latestGitHubVersion.toString()} @@ -37,4 +37,4 @@ export const LatestGitHubRelease: FC = () => {
) -} +} \ No newline at end of file diff --git a/SharePointFramework/PortfolioExtensions/src/components/Footer/InstallVersionTooltipContent/LatestGitHubRelease/useLatestGitHubRelease.ts b/SharePointFramework/PortfolioExtensions/src/components/Footer/InstallVersionTooltipContent/LatestGitHubRelease/useLatestGitHubRelease.ts index 42d40fc685..bb1cc8a635 100644 --- a/SharePointFramework/PortfolioExtensions/src/components/Footer/InstallVersionTooltipContent/LatestGitHubRelease/useLatestGitHubRelease.ts +++ b/SharePointFramework/PortfolioExtensions/src/components/Footer/InstallVersionTooltipContent/LatestGitHubRelease/useLatestGitHubRelease.ts @@ -3,6 +3,11 @@ import strings from 'PortfolioExtensionsStrings' import { useContext } from 'react' import { FooterContext } from '../../context' +/** + * Component logic hook for the `LatestGitHubRelease` component. + * Returns the latest GitHub release, latest GitHub version, installed + * version and version comparison icon props. + */ export function useLatestGitHubRelease() { const { props } = useContext(FooterContext) const latestGitHubRelease = props.gitHubReleases[0] diff --git a/SharePointFramework/PortfolioExtensions/src/components/Footer/InstallVersionTooltipContent/index.tsx b/SharePointFramework/PortfolioExtensions/src/components/Footer/InstallVersionTooltipContent/index.tsx index 6256eee8c8..7c2efc592e 100644 --- a/SharePointFramework/PortfolioExtensions/src/components/Footer/InstallVersionTooltipContent/index.tsx +++ b/SharePointFramework/PortfolioExtensions/src/components/Footer/InstallVersionTooltipContent/index.tsx @@ -5,6 +5,10 @@ import { FooterContext } from '../context' import styles from './InstallVersionTooltipContent.module.scss' import { LatestGitHubRelease } from './LatestGitHubRelease' +/** + * Component for displaying information about the latest installation + * of Prosjektportalen 365. + */ export const InstallVersionTooltipContent: FC = () => { const { latestEntry, props } = useContext(FooterContext) const dateTimeFormatOptions: Intl.DateTimeFormatOptions = { diff --git a/SharePointFramework/PortfolioExtensions/src/components/Footer/useFooter.ts b/SharePointFramework/PortfolioExtensions/src/components/Footer/useFooter.ts index a71325c703..a2df2b9a67 100644 --- a/SharePointFramework/PortfolioExtensions/src/components/Footer/useFooter.ts +++ b/SharePointFramework/PortfolioExtensions/src/components/Footer/useFooter.ts @@ -2,7 +2,8 @@ import { IFooterProps } from './types' /** * Component logic hook for the `Footer` component. Returns the latest entry - * from the `entries` prop (which is sorted by `InstallStartTime`). + * from the `entries` prop (which is sorted by `InstallStartTime`) and + * the installed version string. * * @param props Props for the `Footer` component */ diff --git a/SharePointFramework/PortfolioExtensions/src/loc/myStrings.d.ts b/SharePointFramework/PortfolioExtensions/src/loc/myStrings.d.ts index 3c4587a069..5ecb4db415 100644 --- a/SharePointFramework/PortfolioExtensions/src/loc/myStrings.d.ts +++ b/SharePointFramework/PortfolioExtensions/src/loc/myStrings.d.ts @@ -1,4 +1,5 @@ declare interface IPortfolioExtensionsStrings { + LatestGitHubReleaseLinkTitle: string LatestGitHubReleaseDownloadButtonText: string LatestGitHubReleaseIsNewerText: any LatestGitHubReleaseIsOlderText: any diff --git a/SharePointFramework/PortfolioExtensions/src/loc/nb-no.js b/SharePointFramework/PortfolioExtensions/src/loc/nb-no.js index 64928aacd8..5adb94cfd0 100644 --- a/SharePointFramework/PortfolioExtensions/src/loc/nb-no.js +++ b/SharePointFramework/PortfolioExtensions/src/loc/nb-no.js @@ -43,6 +43,7 @@ define([], function () { LatestGitHubReleaseIsNewerText: 'En nyere versjon er tilgjengelig på GitHub', LatestGitHubReleaseIsOlderText: 'Versjonen som er installert er nyere enn den siste release fra GitHub', LatestGitHubReleaseIsSameText: 'Versjonen som er installert er den siste release fra GitHub', - LatestGitHubReleaseDownloadButtonText: 'Last ned siste release fra GitHub' + LatestGitHubReleaseDownloadButtonText: 'Last ned siste release fra GitHub', + LatestGitHubReleaseLinkTitle: 'Se siste release på GitHub' } }) \ No newline at end of file