Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Wokwi CI issue #8

Closed
jcelerier opened this issue Nov 27, 2024 · 5 comments
Closed

Fix the Wokwi CI issue #8

jcelerier opened this issue Nov 27, 2024 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@jcelerier
Copy link
Collaborator

Now that things are merged we can look into fixing the CI issue.

this one looks just like a path mistake: https://github.com/Puara/puara-module-templates/actions/runs/12054036327

 Error: diagram file not found in /home/runner/work/puara-module-templates/puara-module-templates/ble-advertising/diagram.json

@satmatthills : so that CI works, I'll invite you to the repo. Please make a branch directly in this repo and not your fork, this way it will have access to the WOKWI_CLI token and we'll be able to see CI turn green hopefully ! :)

@jcelerier jcelerier added the bug Something isn't working label Nov 27, 2024
@satmatthills
Copy link
Collaborator

Cool thanks I think I see the problem actually. I'll try to fix it tomorrow (or today if I end up having time)

@jcelerier
Copy link
Collaborator Author

jcelerier commented Nov 27, 2024

super thanks ! :)

@satmatthills
Copy link
Collaborator

Works now for ESP32-S3s and skips all others. #9

The way I understand Wokwi cli is that we’d have to have a seperate wokwi.toml and diagram.json for every template/environment combination and therefore a separate directory for each. Which would be a lot. My instinct says there’s a better way but I don’t see it yet. Maybe this is enough for now and we could open a separate issue for other boards?

@vberthiaume
Copy link
Member

seconding @satmatthills here: I think we're good to close this issue and reopen one when/if we want the CI to test more than just the ESP32-S3 wokwi diagrams? @jcelerier @edumeneses

@jcelerier
Copy link
Collaborator Author

ok !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants