-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the Wokwi CI issue #8
Comments
Cool thanks I think I see the problem actually. I'll try to fix it tomorrow (or today if I end up having time) |
super thanks ! :) |
Works now for ESP32-S3s and skips all others. #9 The way I understand Wokwi cli is that we’d have to have a seperate wokwi.toml and diagram.json for every template/environment combination and therefore a separate directory for each. Which would be a lot. My instinct says there’s a better way but I don’t see it yet. Maybe this is enough for now and we could open a separate issue for other boards? |
seconding @satmatthills here: I think we're good to close this issue and reopen one when/if we want the CI to test more than just the ESP32-S3 wokwi diagrams? @jcelerier @edumeneses |
ok ! |
Now that things are merged we can look into fixing the CI issue.
this one looks just like a path mistake: https://github.com/Puara/puara-module-templates/actions/runs/12054036327
@satmatthills : so that CI works, I'll invite you to the repo. Please make a branch directly in this repo and not your fork, this way it will have access to the WOKWI_CLI token and we'll be able to see CI turn green hopefully ! :)
The text was updated successfully, but these errors were encountered: