Whip buff for NPC detected cheating false positive

[sgkoishi]

• TShock version: general-dev

Reproduction steps (if applicable)?

1. Use the whip (summoner weapon) to attack, inflict buff to NPCs
2. Get kicked for Added buff to NPC abnormally.

Any stack traces or error messages (if known)?

TShock/TShockAPI/Bouncer.cs

Lines 1872 to 1895 in 3471646

	private static Dictionary<int, short> NPCAddBuffTimeMax = new Dictionary<int, short>()
	{
	{ BuffID.Poisoned, 3600 },
	{ BuffID.OnFire, 1200 },
	{ BuffID.CursedInferno, 420 },
	{ BuffID.Frostburn, 900 },
	{ BuffID.Ichor, 1200 },
	{ BuffID.Venom, 1260 },
	{ BuffID.Midas, 120 },
	{ BuffID.Wet, 1500 },
	{ BuffID.Slimed, 1500 },
	{ BuffID.Lovestruck, 1800 },
	{ BuffID.Stinky, 1800 },
	{ BuffID.SoulDrain, 30 },
	{ BuffID.ShadowFlame, 660 },
	{ BuffID.DryadsWard, 120 },
	{ BuffID.BoneJavelin, 900 },
	{ BuffID.StardustMinionBleed, 900 },
	{ BuffID.DryadsWardDebuff, 120 },
	{ BuffID.BetsysCurse, 600 },
	{ BuffID.Oiled, 540 },
	{ BuffID.Confused, 450 }, // Brain of Confusion Internal Item ID: 3223
	{ BuffID.Daybreak, 300 } // Solar Eruption Item ID: 3473, Daybreak Item ID: 3543
	};

TShock/TShockAPI/Bouncer.cs

Lines 1382 to 1407 in 3471646

	if (NPCAddBuffTimeMax.ContainsKey(type))
	{
	if (time > NPCAddBuffTimeMax[type])
	{
	detectedNPCBuffTimeCheat = true;
	}
	if (npc.townNPC && npc.netID != NPCID.Guide && npc.netID != NPCID.Clothier)
	{
	if (type != BuffID.Lovestruck && type != BuffID.Stinky && type != BuffID.DryadsWard &&
	type != BuffID.Wet && type != BuffID.Slimed)
	{
	detectedNPCBuffTimeCheat = true;
	}
	}
	}
	else
	{
	detectedNPCBuffTimeCheat = true;
	}
	if (detectedNPCBuffTimeCheat)
	{
	args.Player.Kick("Added buff to NPC abnormally.", true);
	args.Handled = true;
	}

Whitelist not updated.

Well I'm not sure if this is 'big' enough to be an issue - just posting here as reminder

[Kojirremer]

#1759
It's being worked on, so fingers crossed.

[sgkoishi]

Aha didn't see that! Lemme see if I can close or mark this duplicate.

[hakusaro]

This should be fixed now! Let me know if it's not!