From 6356266dd8ed858db277ca55fdfbe80d2ebbcfad Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jaroslav=20Ozevi=C4=8D?= Date: Wed, 28 Feb 2024 15:24:19 +0200 Subject: [PATCH] fix: disable sentry on iOS https://github.com/getsentry/sentry-cocoa/issues/1892 is not fixed, or the fix was not enough for us to get sentry back working. We still get crash reports where the source of the crash is reported as Sentry itself. --- apps/ios/ProtonVPN/AppDelegate.swift | 24 +++++++++++++----------- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/apps/ios/ProtonVPN/AppDelegate.swift b/apps/ios/ProtonVPN/AppDelegate.swift index ac5ca9879..6b05bee3a 100644 --- a/apps/ios/ProtonVPN/AppDelegate.swift +++ b/apps/ios/ProtonVPN/AppDelegate.swift @@ -104,17 +104,19 @@ extension AppDelegate: UIApplicationDelegate { // Protocol check is placed here for parity with MacOS adjustGlobalProtocolIfNecessary() - if FeatureFlagsRepository.shared.isEnabled(VPNFeatureFlagType.sentry) { - SentryHelper.setupSentry( - dsn: ObfuscatedConstants.sentryDsniOS, - isEnabled: { [weak self] in - self?.container.makeTelemetrySettings().telemetryCrashReports ?? false - }, - getUserId: { [weak self] in - self?.container.makeAuthKeychainHandle().userId - } - ) - } + // Sentry turned off, because https://github.com/getsentry/sentry-cocoa/issues/1892 + // is still not fixed. +// if FeatureFlagsRepository.shared.isEnabled(VPNFeatureFlagType.sentry) { +// SentryHelper.setupSentry( +// dsn: ObfuscatedConstants.sentryDsniOS, +// isEnabled: { [weak self] in +// self?.container.makeTelemetrySettings().telemetryCrashReports ?? false +// }, +// getUserId: { [weak self] in +// self?.container.makeAuthKeychainHandle().userId +// } +// ) +// } AnnouncementButtonViewModel.shared = container.makeAnnouncementButtonViewModel()