Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

encode buffers as hex instead of array of bytes in json tests ? #66

Open
rom1504 opened this issue Mar 14, 2016 · 2 comments
Open

encode buffers as hex instead of array of bytes in json tests ? #66

rom1504 opened this issue Mar 14, 2016 · 2 comments

Comments

@rom1504
Copy link
Member

rom1504 commented Mar 14, 2016

new Buffer("381905","hex") instead of new Buffer([0x38,0x19,0x05],"hex")
Kind of shorter and clearer.
@Saiv46
Copy link
Contributor

Saiv46 commented Jun 13, 2020

Close this issue, we have Buffer.from

@rom1504
Copy link
Member Author

rom1504 commented Jun 13, 2020

Yes the point of the issue is to do that change. It's not done. Is it ?

@Saiv46 Saiv46 mentioned this issue Jan 2, 2021
Closed
@Saiv46 Saiv46 mentioned this issue Sep 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Decode buffers as hex
2 participants
@rom1504 @Saiv46