Skip to content
This repository has been archived by the owner on May 9, 2023. It is now read-only.

Incorrect Pagination leading to missing results #57

Open
roama3 opened this issue Dec 15, 2022 · 0 comments
Open

Incorrect Pagination leading to missing results #57

roama3 opened this issue Dec 15, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@roama3
Copy link

roama3 commented Dec 15, 2022

Describe the bug
Missing data due to Incorrect pagination.

To Reproduce
Steps to reproduce the behavior:
Query any subgraph which has e.g. a "timestamp" and should return > 1800 entities. After the first pagination, instead of using "skip: 1800" and "first: 900", in my case it uses "skip: 0", "first: 900" and "timestamp_gt: $lastOrderingValue0".
If the timestamp of result with index 1800 is the same as 1801, this will skip 1801 and any other events which happen to have the same timestamp as index 1800.

Expected behavior
Results with same timestamp as the last returned timestamp from the previous result set of the pagination are present.

Sorry I'm not experienced enough with the library to understand how it determines over which field to paginate - a briefer summary is that pagination shouldn't occur over fields which are not guaranteed to be unique.

@roama3 roama3 added the bug Something isn't working label Dec 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant