You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The plugin currently allows saving annotations without selecting a target region on the Canvas. This would be fine (I think), but the annotation can not be edited because an error occurs in the AnnotationCreation constructor. props.annotation.target.selector` is undefined in the following line:
Alternatively, saving an annotation without a selector should not be allowed. But if an annotation store provides annotations from a different source than Mirador, the error might still occur.
The text was updated successfully, but these errors were encountered:
The plugin currently allows saving annotations without selecting a target region on the Canvas. This would be fine (I think), but the annotation can not be edited because an error occurs in the
AnnotationCreation constructor.
props.annotation.target.selector` is undefined in the following line:mirador-annotations/src/AnnotationCreation.js
Line 62 in d6b55e0
I'd suggest to just put a check for
props.annotation.target.selector
around this block:mirador-annotations/src/AnnotationCreation.js
Lines 53 to 63 in d6b55e0
Alternatively, saving an annotation without a selector should not be allowed. But if an annotation store provides annotations from a different source than Mirador, the error might still occur.
The text was updated successfully, but these errors were encountered: