Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linting and formatting support for code snippets inside markdown #43

Closed
thescientist13 opened this issue May 3, 2024 · 0 comments
Closed
Assignees
Labels
chore project maintenance related tasks

Comments

@thescientist13
Copy link
Member

Summary

Coming out of our experience in ProjectEvergreen/greenwood#1215, for the time being since ESLint doesn't support Import Attributes, without using a custom parser, e.g.

module.exports = {
  parser: '@babel/eslint-parser',
  parserOptions: {
    ecmaVersion: 2022,
    sourceType: 'module',
    requireConfigFile: false,
    babelOptions: {
      plugins: [
        '@babel/plugin-syntax-import-assertions'
      ],
    }
  }
  // ...
}

However, as has been added to this Discussion, the markdown plugin for ESLint doesn't seem to play well with a custom parser 😢

Details

So the hope here is that either:

  1. ESLint finally gets Import Attributes, and so no custom parser is needed

or

  1. markdown plugin can play nice with custom parsers
@thescientist13 thescientist13 added the chore project maintenance related tasks label May 3, 2024
@thescientist13 thescientist13 changed the title linting and formatting support for code snippets inside markdown (Import Attributes parsing support in ESLint) linting and formatting support for code snippets inside markdown May 3, 2024
@thescientist13 thescientist13 removed this from the Website Redesign and Relaunch milestone Sep 5, 2024
@thescientist13 thescientist13 moved this from 📋 Backlog to 🏗 In progress in [Greenwood] Website Redesign and Relaunch Oct 4, 2024
@thescientist13 thescientist13 moved this from 🏗 In progress to 👀 In review in [Greenwood] Website Redesign and Relaunch Oct 4, 2024
@thescientist13 thescientist13 self-assigned this Oct 4, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in [Greenwood] Website Redesign and Relaunch Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore project maintenance related tasks
Projects
Development

No branches or pull requests

1 participant