Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTMLTemplateElement should not have a set innerHTML method #15

Closed
thescientist13 opened this issue May 1, 2022 · 0 comments · Fixed by #139
Closed

HTMLTemplateElement should not have a set innerHTML method #15

thescientist13 opened this issue May 1, 2022 · 0 comments · Fixed by #139
Assignees
Labels
0.11.0 bug Something isn't working
Milestone

Comments

@thescientist13
Copy link
Member

Type of Change

  • Bug

Summary

Our current implementation for HTMLTemplateElement includes a setInnerHTML method.

class HTMLTemplateElement extends HTMLElement {
  constructor() {
    super();
    // console.debug('HTMLTemplateElement constructor');

    this.content = new DocumentFragment(this.innerHTML);
  }

  set innerHTML(html) {
    this.content.textContent = html;
  }
}

But according to MDN, that doesn't seem correct.

Details

The issue is I'm not sure where it goes? Without it, I'm not sure how setting innerHTML on a <template> and thus how to get that when using cloneNode? 🤔

@thescientist13 thescientist13 added the bug Something isn't working label May 1, 2022
@thescientist13 thescientist13 added this to the 1.0 milestone May 1, 2022
@thescientist13 thescientist13 self-assigned this May 1, 2022
@thescientist13 thescientist13 moved this to 📋 Backlog in [WCC] General Activities Dec 28, 2022
@thescientist13 thescientist13 moved this from 📋 Backlog to 🏗 In progress in [WCC] General Activities Jan 10, 2024
@thescientist13 thescientist13 moved this from 🏗 In progress to 👀 In review in [WCC] General Activities Jan 10, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in [WCC] General Activities Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.11.0 bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant