async import() puppeteer only if used when default prerendering
#927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thescientist13
added
bug
This was referenced Apr 2, 2022
Merged
thescientist13
changed the title
thescientist13
changed the title
import() browser.js only if used when default prerendering
thescientist13
deleted the
bug/issue-916-static-compilation-breaks-puppeteer-not-found
branch
thescientist13
changed the title
import() browser.js only if used when default prerenderingimport() puppeteer only if used when default prerendering
5 tasks
thescientist13
added a commit
that referenced
this pull request
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
#916
Realized, due to having puppeteer as a
devDependencyin the monorepo, and other projects I tested having it as a transitive dependency, i wasn't shielding puppeteer away enough. Basically, even if runningbuildfor a static compilation, lifecycles/prerender.js is still getting loaded and so is still going load puppeteer. 🤦Seeing this behavior in thescientist13/greenwood-starter-presentation#56
Summary of Changes
preRenderCompilationDefault