Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/issue 881 favor content over configuration eg meta #892

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Feb 17, 2022

Related Issue

resolves #881

Invalidates:

Summary of Changes

  1. title and meta configurations are no longer supported in greenwood.config.js
  2. Updated docs and specs accordingly (as now many specs don't even need a config file! 🎉 )
  3. Migrated www/ config to use <title> and <meta> tags in HTML with interpolateFrontmatter
  4. Updated _Getting Started_guide accordingly

TODO

  1. Move www/ meta and title out of greenwood.config.js and take advantage of interpolateFrontmatter for og meta tags
  2. update greenwood-getting-started repo - Enhancment/issue 881 update for content over configuration greenwood-getting-started#59
  3. update greenwood-template-blog repo (if needed) - Enhancement/issue 881 update for content over configuration greenwood-template-blog#3
  4. Need to wait for ensure SPA does not prerender by default #891

Discussion

  1. Issue title configuration should accept a (formatting) function as an option #655 could still be useful maybe?
  2. Could ensure unique keys for <meta> / when lower page / template overrides parent page / template? - added as tracking to my personal backlog

@thescientist13 thescientist13 added enhancement Improve something existing (e.g. no docs, new APIs, etc) CLI breaking discussion tied to an ongoing discussion or meeting notes labels Feb 17, 2022
@thescientist13 thescientist13 self-assigned this Feb 18, 2022
@thescientist13 thescientist13 added the documentation Greenwood specific docs label Feb 18, 2022
@thescientist13 thescientist13 force-pushed the enhancement/issue-881-favor-content-over-configuration-eg-meta branch from 9cfbff5 to d69f7cb Compare February 19, 2022 17:39
@thescientist13 thescientist13 marked this pull request as ready for review February 19, 2022 17:39
@thescientist13 thescientist13 removed their assignment Mar 3, 2022
@thescientist13 thescientist13 force-pushed the enhancement/issue-881-favor-content-over-configuration-eg-meta branch from d69f7cb to dfd78c7 Compare March 3, 2022 02:53
@thescientist13 thescientist13 force-pushed the enhancement/issue-881-favor-content-over-configuration-eg-meta branch from dfd78c7 to e5302dd Compare March 5, 2022 16:11
@thescientist13 thescientist13 merged commit 187e12f into master Mar 5, 2022
@thescientist13 thescientist13 deleted the enhancement/issue-881-favor-content-over-configuration-eg-meta branch March 5, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking CLI discussion tied to an ongoing discussion or meeting notes documentation Greenwood specific docs enhancement Improve something existing (e.g. no docs, new APIs, etc)
Projects
None yet
1 participant