Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better handle the duality of @greenwood node modules resolution #722

Merged

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Sep 10, 2021

Related Issue

related to #557 and fixing an observed issue as part of the v01.16.0-alpha.0 - thegreenhouseio/www.thegreenhouse.io#244

Screen Shot 2021-09-10 at 4 57 48 PM

Note: there is a discussion for track refactoring this kind of stuff - #623

Summary of Changes

  1. Correctly handle @greenwood scope when auto resolving node_modules

@thescientist13 thescientist13 added bug Something isn't working P0 Critical issue that should get addressed ASAP CLI alpha.1 v0.16.0 labels Sep 10, 2021
@thescientist13 thescientist13 merged commit ac5baee into master Sep 10, 2021
@thescientist13 thescientist13 deleted the bug/issue-557-fix-scoped-package-auto-resolution branch September 10, 2021 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLI P0 Critical issue that should get addressed ASAP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

leverage NodeJS resolve logic for looking up location of paths for node modules
1 participant