Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bad logic for filtering workspace files to resolve #608

Merged
merged 1 commit into from
May 15, 2021
Merged

fix bad logic for filtering workspace files to resolve #608

merged 1 commit into from
May 15, 2021

Conversation

thescientist13
Copy link
Member

Related Issue

resolves #598

Summary of Changes

  1. Actually test for the complete URL by using path.join

@thescientist13 thescientist13 added bug Something isn't working P0 Critical issue that should get addressed ASAP CLI labels May 15, 2021
@thescientist13 thescientist13 changed the title fix bad logic fix bad logic for filtering workspace files to resolve May 15, 2021
@thescientist13 thescientist13 merged commit a89e99d into master May 15, 2021
@thescientist13 thescientist13 deleted the bug/issue-598-fix-dev-server-proxy-url-preservation-again branch May 15, 2021 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working CLI P0 Critical issue that should get addressed ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dev server proxy is not forwarding query params
1 participant
@thescientist13