Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/issue 309 Fix Page Scroll On Initial Load #310

Merged
merged 2 commits into from
Apr 24, 2020

Conversation

hutchgrant
Copy link
Member

@hutchgrant hutchgrant commented Mar 26, 2020

Related Issue

Resolves #309

Summary of Changes

  • Disable Page scroll if no anchor in URL

Currently and with Fix

@hutchgrant hutchgrant added the website Tasks related to the projects website / documentation label Mar 26, 2020
Copy link
Member

@thescientist13 thescientist13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you confirm if this exists in the release/0.5.0 branch? Maybe just to avoid any more conflicts with master, we should consider merging it into there? Or since this is just "for the website" we wait until after we merge release/0.5.0?

@hutchgrant
Copy link
Member Author

hutchgrant commented Apr 7, 2020

Can you confirm if this exists in the release/0.5.0 branch? Maybe just to avoid any more conflicts with master, we should consider merging it into there? Or since this is just "for the website" we wait until after we merge release/0.5.0?

It exists on release/0.5.0 branch as well. As you pointed out it's related to our website only so not necessary to be included in release branch and probably better just to merge to master.

Copy link
Member

@thescientist13 thescientist13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Along with PRs like #308, seems like we are patching around the surface when it comes managing these page specific route loadings, due to a /. Made an issue to track this more fundamentally, but we should at least make these spot fixes when we see them.

Will queue this up for merge after we merge release/0.5.0 into master within the next week.

@thescientist13 thescientist13 merged commit 864bb89 into master Apr 24, 2020
@thescientist13 thescientist13 deleted the bug/issue-309-initial-auto-scrolling branch April 24, 2020 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
website Tasks related to the projects website / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Page automatically scrolling to first h3 tag
2 participants