Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement/Issue-1087: Upgrade Rollup to latest 3.x.x #1187

Merged
merged 5 commits into from
Mar 9, 2024

Conversation

DevLab2425
Copy link
Contributor

@DevLab2425 DevLab2425 commented Dec 4, 2023

Related Issue

Fix: #1087

Summary of Changes

  1. Ran yarn upgrade for rollup in the CLI
    • The collection of @rollup/ packages support [email protected]. A yarn upgrade was run, but there was no impact to the current lockfile for those dependencies.
    • After a deeper dive, each of the plugins does have a version greater than the version listed, which was initially overlooked. A dedicated upgrade was done to the latest major.
  2. Upgrade all Rollup dependencies in plugins
  3. Update test cases as needed (mainly for updated file name hashes)

TODO

  1. Fix home page Get Started button not working - enhancement/Issue-1087: Upgrade Rollup to latest 3.x.x  #1187 (comment)

@DevLab2425 DevLab2425 changed the title Issue-1087: Initial upgrade of Rollup and @rollup plugins Issue-1087: Upgrade Rollup to latest 3.x.x Dec 4, 2023
@thescientist13 thescientist13 added enhancement Improve something existing (e.g. no docs, new APIs, etc) Plugins Greenwood Plugins CLI labels Dec 7, 2023
@thescientist13
Copy link
Member

Now that #1190 has been merged, I would rebase this branch against master to help clear up any related test failures.

@thescientist13
Copy link
Member

Had a little time to circle back on this and was able to rebase and get all the test cases passing along with updating any Rollup dependencies used in our other packages.

There does seem to be one issue though, in that a production build of the website is missing a script file reference for the Get Started button on the home page and a 404 on the script asset (though interestingly there is a 756510913.js in the .greenwood/ folder, where assets are collected prior to final bundling 🤔 )

Screenshot 2024-02-15 at 9 41 04 PM

As opposed to what it should look like
Screenshot 2024-02-15 at 9 06 38 PM

Will see if there is anything of note in the Rollup v3 changelog and start taking a look, but we're almost this almost there!

@thescientist13 thescientist13 self-assigned this Feb 16, 2024
@thescientist13
Copy link
Member

Got if fixed, I think duplicate imports of the <eve-container> custom element definition may have been throwing things off, possibly being treated as side effects. Will see if I can gather more conclusive proof, but surprised we actually didn't custom element registries with the previous implementation. 😬
Screenshot 2024-02-15 at 9 58 26 PM

@thescientist13 thescientist13 marked this pull request as ready for review February 16, 2024 03:14
@thescientist13 thescientist13 removed their assignment Feb 16, 2024
Copy link
Member

@thescientist13 thescientist13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heck yes!

@thescientist13 thescientist13 changed the title Issue-1087: Upgrade Rollup to latest 3.x.x enhancement/Issue-1087: Upgrade Rollup to latest 3.x.x Feb 18, 2024
@thescientist13 thescientist13 changed the base branch from master to release/0.30.0 March 9, 2024 20:07
@thescientist13 thescientist13 force-pushed the issue-1087-update-rollup-and-friends branch from 21392b6 to 4081f23 Compare March 9, 2024 23:22
@thescientist13 thescientist13 merged commit 787055f into release/0.30.0 Mar 9, 2024
4 checks passed
@thescientist13 thescientist13 deleted the issue-1087-update-rollup-and-friends branch March 9, 2024 23:42
thescientist13 added a commit that referenced this pull request Jun 1, 2024
* Issue-1087: Initial upgrade of Rollup and @rollup plugins

* Issue-1087: Upgrade plugin dependencies

* upgrade all test cases with new hash matchers

* update all plugin rollup deps and breaking change updates

* fix duplicate imports of eve-container custom element definition

---------

Co-authored-by: Owen Buckley <[email protected]>
thescientist13 added a commit that referenced this pull request Nov 2, 2024
* Issue-1087: Initial upgrade of Rollup and @rollup plugins

* Issue-1087: Upgrade plugin dependencies

* upgrade all test cases with new hash matchers

* update all plugin rollup deps and breaking change updates

* fix duplicate imports of eve-container custom element definition

---------

Co-authored-by: Owen Buckley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI enhancement Improve something existing (e.g. no docs, new APIs, etc) Plugins Greenwood Plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrade Rollup and all plugins to 3.x
2 participants