Bug/issue 1059 api routes and api calls overlap #1062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thescientist13
force-pushed
the
bug/issue-1059-api-routes-and-api-calls-overlap
branch
from
6fc1bd7 to
6602494
Compare
thescientist13
commented
Feb 18, 2023
There was a problem hiding this comment.
In light of #1070 , just wanted to capture that after a rebase, all the specs are at least passing locally
2582 passing (5m)
28 pending
thescientist13
force-pushed
the
bug/issue-1059-api-routes-and-api-calls-overlap
branch
from
6602494 to
84e630f
Compare
thescientist13
deleted the
bug/issue-1059-api-routes-and-api-calls-overlap
branch
thescientist13
added a commit
that referenced
this pull request
Apr 9, 2023
* better handle detecting and serving API routes and not confusing with /api requests * add test case for API proxy and API routes overlap for serve command * remove runner logging
thescientist13
added a commit
that referenced
this pull request
Apr 9, 2023
* better handle detecting and serving API routes and not confusing with /api requests * add test case for API proxy and API routes overlap for serve command * remove runner logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
resolves #1059
Summary of Changes
/api*callsTODO