Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<script> tags in the <body> are not getting bundled #994

Closed
1 of 5 tasks
thescientist13 opened this issue Nov 2, 2022 · 0 comments · Fixed by #995
Closed
1 of 5 tasks

<script> tags in the <body> are not getting bundled #994

thescientist13 opened this issue Nov 2, 2022 · 0 comments · Fixed by #995
Assignees
@thescientist13
Labels
alpha.2 bug Something isn't working CLI P0 Critical issue that should get addressed ASAP v0.27.0
Milestone
1.0

Comments

@thescientist13
Copy link
Member

thescientist13 commented Nov 2, 2022 •
edited
Loading

Type of Change

  • New Feature Request
  • Documentation / Website
  • Improvement / Suggestion
  • Bug
  • Other (please clarify below)

Summary

When downstream testing the latest alpha releases of Greenwood for v0.27.0, it looks like in the case of the presentation starter, where there are <script> tags in the <body>
https://github.com/thescientist13/greenwood-starter-presentation/blob/0.6.0/src/layouts/page.html

<html>
  <head>...</head>
  <body>
    <h1>Content</h1>
    
    <script src="/scripts/popup.js"></script>
  </body>
</html>

it looks like they are not getting bundled correctly.
thescientist13/greenwood-starter-presentation#61
image

Details

While a <script type="module"> is defer by default, there are certain cases where putting a <script>` tag in the body makes sense. In general, want to try and be as faithful as possible to the source code a developer writes.
@thescientist13 thescientist13 added bug Something isn't working P0 Critical issue that should get addressed ASAP CLI v0.27.0 labels Nov 2, 2022
@thescientist13 thescientist13 added this to the 1.0 milestone Nov 2, 2022
@thescientist13 thescientist13 self-assigned this Nov 2, 2022
This was referenced Nov 2, 2022
Merged
Merged
@thescientist13 thescientist13 mentioned this issue Nov 2, 2022
Merged
27 tasks
@thescientist13 thescientist13 linked a pull request Nov 3, 2022 that will close this issue
properly bundle all <script> tags #995
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thescientist13 thescientist13

Labels
alpha.2 bug Something isn't working CLI P0 Critical issue that should get addressed ASAP v0.27.0
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

properly bundle all <script> tags ProjectEvergreen/greenwood
1 participant
@thescientist13