-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
assets are being fetched twice from different hosts #404
Comments
Seems to be happening with fonts too as part of #402, which loads fonts from /assets/ |
@hutchgrant / @aholtzman
nm: looks like it is happening now that I am looking. oh well. 🤷♂️ On a related note, I wonder if we should benchmark with and without Netlify asset optimization? I wonder if it would be better to make sure Greenwood is doing that all on its own, so it either doens't conflict with what Netlify is trying to do, or unintentionally gets a boost that makes it seem to only work better on Netlify. (e.g. false positive). Thoughts? |
I'd like to see the difference with and without optimization. Why don't you turn it off and recompile site and test both(I don't have access to greenwood's netlify). I know, testing production is bad. For 5 minutes, it shouldn't be that big a deal. |
OK, disabled this all completely in prod and rebuilt and cleared the site cache via Netlify And things are looking much better! Less requests / payload size overall (as expected) with no more CloudFront urls. Found this thread where others reported similar issues but I'm pretty sure Netlify already serves everything off of a CDN anyway so losing the CloudFront specific routes shouldn't be a big deal anyway, and our score definitely didn't get harmed, so I say this is a winner. I think I'll create a PR to add a netlify.toml for this and other settings, so we can track stuff like this and #331 via code. |
We should definitely look into font / image preloading though, I think that would be super helpful to have a solution / best practice for. |
can we close this issue then. Loading seems smoother. |
Shortly, will make some notes in our guides and introduce a netlify.toml first. Doing that now. |
Type of Change
Summary
Images are being fetched twice, once from assets/* and another call from CloudFront (Netlify).
Details
Could just be a Netlify setting?
But ideally, we would want these images served from a CDN though... wonder if we can get the best of both worlds? 🤔
The text was updated successfully, but these errors were encountered: