Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support custom PostCSS / Babel configurations #365

Closed
1 of 5 tasks
thescientist13 opened this issue Jun 11, 2020 · 0 comments · Fixed by #366
Closed
1 of 5 tasks

support custom PostCSS / Babel configurations #365

thescientist13 opened this issue Jun 11, 2020 · 0 comments · Fixed by #366
Assignees
Labels
documentation Greenwood specific docs enhancement Improve something existing (e.g. no docs, new APIs, etc) v0.7.0 webpack (and friends) customizations

Comments

@thescientist13
Copy link
Member

Type of Change

  • New Feature Request
  • Documentation / Website
  • Improvement / Suggestion
  • Bug
  • Other (please clarify below)

Summary

Currently there is no way to extend Greenwood's built in Babel and PostCSS configuration, to either add custom plugins or additional stages, as seen in #363 .

Details

In webpack.config.common.js the relative config files for both are provided and loaded. We should update this to

  1. Detect if equivalent file is found in users project directory
  2. Use that version instead
  3. Document in the website the new behavior
  4. Add a test (I suppose detecting transpiled features in the output would have to the be test?)

Only immediate thought that comes to mind that might make this tricky is that both assume the relative location of .browserslistrc which may differ now when the Babel and PostCSS files are loaded from a different location now. Not sure if .browserslistrc path can be hardcoded or configured on the fly in that case? Seems like this enhancement could / should be done along with #224 ?

@thescientist13 thescientist13 added enhancement Improve something existing (e.g. no docs, new APIs, etc) documentation Greenwood specific docs labels Jun 11, 2020
@thescientist13 thescientist13 added the v0.7.0 webpack (and friends) customizations label Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Greenwood specific docs enhancement Improve something existing (e.g. no docs, new APIs, etc) v0.7.0 webpack (and friends) customizations
Projects
None yet
2 participants