Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

babel configuration not being used #256

Closed
1 of 5 tasks
thescientist13 opened this issue Nov 13, 2019 · 0 comments · Fixed by #257
Closed
1 of 5 tasks

babel configuration not being used #256

thescientist13 opened this issue Nov 13, 2019 · 0 comments · Fixed by #257
Assignees
Labels
bug Something isn't working CLI P0 Critical issue that should get addressed ASAP v0.4.2
Milestone

Comments

@thescientist13
Copy link
Member

Type of Change

  • New Feature Request
  • Documentation / Website
  • Improvement / Suggestion
  • Bug
  • Other (please clarify below)

Summary

It appears as part of the discovery done into #198 , that our project's babel configuration configuration wasn't getting used at all. 😬

Details

By default, babel will look for a babel.config.js in the root of the project. However, our Babel configuration is in a folder in packages. This means that it was never getting used.

Similar to PostCSS config

const commonCssLoaders = [
  { loader: 'css-loader' },
  {
    loader: 'postcss-loader',
    options: {
      config: {
        path: path.join(__dirname, 'postcss.config.js')
      }
    }
  }
];

We would need to programmatically detect for babel config, e.g.

module: {
  rules: [{
    test: /\.js$/,
    loader: 'babel-loader',
    options: {
      configFile: path.join(__dirname, 'babel.config.js'),
    }
  }]

This does bring up a question, is browserslist also getting ignored? 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLI P0 Critical issue that should get addressed ASAP v0.4.2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant