Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

loading performance impacted due to lack of polyfills minification #169

Closed
1 of 5 tasks
thescientist13 opened this issue Aug 17, 2019 · 2 comments · Fixed by #174
Closed
1 of 5 tasks

loading performance impacted due to lack of polyfills minification #169

thescientist13 opened this issue Aug 17, 2019 · 2 comments · Fixed by #174
Assignees
@thescientist13
Labels
bug Something isn't working v0.3.5
Milestone
1.0

Comments

@thescientist13
Copy link
Member

thescientist13 commented Aug 17, 2019 •
edited
Loading

Type of Change

  • New Feature Request
  • Documentation / Website
  • Improvement / Suggestion
  • Bug
  • Other (please clarify below)

Summary

Short of completing differential loading there are probably still some improvements we could make to how our polyfills are being loaded, as per Lighthouse by minifying files.
Screen Shot 2019-08-17 at 2 08 50 PM

Details

Currently these two polyfills account for 80KB, which is a lot.
Screen Shot 2019-08-17 at 2 04 46 PM

For example, the minified version of polyfills.js is 213KB!!! (vs 50.2KB)

Should see the same for web-components-bundle.js.

Also, we should probably add some unit tests for this in our smoke test.
@thescientist13 thescientist13 added the enhancement Improve something existing (e.g. no docs, new APIs, etc) label Aug 17, 2019
@thescientist13 thescientist13 added this to the MVP milestone Aug 17, 2019
@thescientist13 thescientist13 self-assigned this Aug 17, 2019
@thescientist13
Copy link
Member Author

thescientist13 commented Aug 17, 2019 •
edited
Loading

Also, doesn't look like our JavaScript bundling is minifying files either (by default)? Maybe we should go with TerserPlugin instead? Also, should we be trying to optimize CSS as well?

@thescientist13
Copy link
Member Author

Are babel polyfills still needed? Find a way to pull them in via npm in #17

@thescientist13 thescientist13 added the bug Something isn't working label Aug 19, 2019
@thescientist13 thescientist13 changed the title improve loading performance of polyfills through minification loading performance impacted due to lack of minification Aug 19, 2019
@thescientist13 thescientist13 removed the enhancement Improve something existing (e.g. no docs, new APIs, etc) label Aug 19, 2019
@thescientist13 thescientist13 mentioned this issue Aug 19, 2019
Merged
2 tasks
@thescientist13 thescientist13 changed the title loading performance impacted due to lack of minification loading performance impacted due to lack of polyfills minification Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thescientist13 thescientist13

Labels
bug Something isn't working v0.3.5
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

improve loading performance / minification for JavaScript polyfills ProjectEvergreen/greenwood
1 participant
@thescientist13